Re-render thumbnails when images change#6
Merged
benhowell merged 1 commit intobenhowell:masterfrom Sep 10, 2016
cust0dian-old:fix-no-render-on-props-change
Merged
Re-render thumbnails when images change#6benhowell merged 1 commit intobenhowell:masterfrom cust0dian-old:fix-no-render-on-props-change
benhowell merged 1 commit intobenhowell:masterfrom
cust0dian-old:fix-no-render-on-props-change
Conversation
Owner
|
Thanks cust0dian, nice pick up! Merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only thumbnails are updated when
imagesprops changes, meaning re-render doesn't happen until window is resized:If you think of a better fix than mine, here's the code I used to replicate this issue.